Fixed memory leak caused by query variables (#5383) #5569
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Thank you for your help! Appreciate it. I will do a review tonight and then we will do a new build for 12. |
|
@michaelstaib did this go into a version 12 release? |
|
@michaelstaib - actually ignore my previous comment - I have been doing further testing with the new fix and the issue still exists due to it not handling List<KeyValuePair<string, object?>> which is what the Formatter generates. I will see if I can create a commit on this branch and a separate one for version 13. |
add handling for List<KeyValuePair<string, object?>> variables
Update ComparisonHelper.cs
|
We are not fixing this anymore in version 12 ... with version 13.1 there is now no more reason to not upgrade. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This backports #5383 to version 12.