Fixed Persisted query opt-in by MSBuild prop #5667
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelstaib
changed the title
michaelstaib
approved these changes
Jan 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since upgrading to v13, Debug builds are always using persisted queries, even if you setup your project with the following to attempt to only opt-in say a Release build.
I believe this is just a copy-paste error here.
Relates to code here in the CLI.
https://github.com/ChilliCream/hotchocolate/blob/bbbaa34048a27bf8a5938405de38ececc5202fbe/src/StrawberryShake/Tooling/src/dotnet-graphql/GenerateCommand.cs#L73-L76
The idea of the string.IsNullOrEmpty is to allow opt-in via the MSBuild prop.