Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated Instrumentation Docs #5971

Merged
merged 3 commits into from
Mar 28, 2023
Merged

Updated Instrumentation Docs #5971

merged 3 commits into from
Mar 28, 2023

Conversation

zkrsyed
Copy link
Contributor

@zkrsyed zkrsyed commented Mar 17, 2023

DataLoader events should inherit from DataLoaderDiagnosticEventListener not ExecutionDiagnosticEventListener

Summary of the changes (Less than 80 chars)

  • Detail 1
  • Detail 2

Closes #bugnumber (in this specific format)

@zkrsyed
Update instrumentation.md
6f6c5b4 
DataLoader events should inherit from DataLoaderDiagnosticEventListener not ExecutionDiagnosticEventListener
@CLAassistant
Copy link

CLAassistant commented Mar 17, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot added the 📚 documentation This issue is about working on our documentation. label Mar 17, 2023
tobias-tengler
tobias-tengler approved these changes Mar 17, 2023
View reviewed changes
Copy link
Collaborator

@tobias-tengler tobias-tengler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you :)

@michaelstaib michaelstaib changed the title Update instrumentation.md Updated Instrumentation Docs Mar 28, 2023
@michaelstaib michaelstaib merged commit 6e9b7a9 into ChilliCream:main Mar 28, 2023
@PascalSenn PascalSenn mentioned this pull request May 9, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tobias-tengler tobias-tengler tobias-tengler approved these changes

@michaelstaib michaelstaib michaelstaib approved these changes

Assignees
No one assigned
Labels
📚 documentation This issue is about working on our documentation.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zkrsyed @CLAassistant @michaelstaib @tobias-tengler