Optimize dataloader fetching for lists #5989
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelstaib
approved these changes
May 19, 2023
|
Kudos, SonarCloud Quality Gate passed! |
michaelstaib
requested changes
May 19, 2023
Qodana for .NET1 new problem were found
💡 Qodana analysis was run in the pull request mode: only the changed files were checked Contact Qodana teamContact us at qodana-support@jetbrains.com
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5989 +/- ##
==========================================
- Coverage 73.03% 69.53% -3.51%
==========================================
Files 2485 2485
Lines 125534 125534
==========================================
- Hits 91690 87285 -4405
- Misses 33844 38249 +4405
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
michaelstaib
force-pushed
the
main
branch
2 times, most recently
from
8a97a79 to
e2d2300
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dataloader currently have a issue with batching.
The first call to "LoadAsync" will initiate a
Scheduleon the batch dispatcher. In a specfic combination of cases, a fetch of a list of keys will lead to two fetches instead of one.What happens is the following. While we are iterating through all the requested keys, the first key will call schedule on the batch dispatcher. When we are calling
LoadAsyncfrom a mutation,Schedulewill immediately dispatch. We continue synchronously and enter reenter the lock of the dataloader that we arleady own. We immediatly fetch with just one key instead of all the keys.