Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed: Authorization Argument Coercion #625

Merged
merged 2 commits into from
Mar 11, 2019

Conversation

eduleite
Copy link
Contributor

@eduleite eduleite commented Mar 11, 2019

This is my suggestion to addresses #624.
Are there other places that the same issue can happen?
It would be interesting to build some test cases to catch this.

@michaelstaib michaelstaib self-requested a review March 11, 2019 11:04
@michaelstaib michaelstaib added this to the 9.0.0 milestone Mar 11, 2019
@michaelstaib
Copy link
Member

Are there other places that the same issue can happen?

@eduleite I am reworking the type system so that this will not happen any more.

Since my change will not by finished by the end of the week I will merge you solution for now.

@michaelstaib michaelstaib changed the title Suggested Fix for #624 Fixed: Authorization Argument Coercion Mar 11, 2019
@michaelstaib michaelstaib merged commit 932a12e into ChilliCream:master Mar 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants