Memory Optimization on Schema #6290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the method
OnAfterInitializein the type discovery context held onto its configuration delegate even after initialization. As a result, all instances used during this initialization phase remained in memory until the schema was phased out, leading to unnecessary static memory allocation.With this change, we now explicitly clear the
_configuredelegate after the initialization phase in theOnAfterInitializemethod. The clearing is performed at this stage because any subsequent calls toInitializewould throw an exception, indicating that the schema has already been initialized and the configuration delegate is no longer needed.