Publicly expose ability to register an error type on a mutation field #6308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This might've been what you were alluding to @michaelstaib when we last spoke. Exposing this to libraries. Assuming it is, just need to address the todo in there and then this could be merged. I don't think I'll back port this to v12. |
|
|
||
| if (descriptorContext.ContextData[MutationContextDataKeys.Options] == null) | ||
| { | ||
| throw new Exception("Mutation convention isn't turned on"); |
There was a problem hiding this comment.
This should be a SchemaException
There was a problem hiding this comment.
Should be OK now
|
Can you add a test that shows this in action? |
|
Thanks for the review. Will get back to this when I can |
|
Hey @michaelstaib, test added and schema exception used (with a resource-file based msg). |
benmccallum
commented
Jul 29, 2023
...__snapshots__/AnnotationBasedMutations.SimpleMutation_Add_Error_Via_Type_Interceptor.graphql
Show resolved
Hide resolved
benmccallum
commented
Jul 29, 2023
michaelstaib
approved these changes
Jul 30, 2023
|
Thanks for this one mate :) |
|
Was this merged into the correct branch? |
benmccallum
added a commit
that referenced
this pull request
Aug 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows libraries to register their own error types in type interceptors (if they can tap in early enough)