-
-
Notifications
You must be signed in to change notification settings - Fork 748
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed issue with variable forwarding in nested fields. #6348
Merged
Merged
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
355c794
add unit test to RequestPlannerTests.cs to ensure variables are passe…
A360JMaxxgamer 7f1129e
add method to add forwarded variables based on the operation
A360JMaxxgamer 5e5037b
Merge branch 'main' into fusion-nested-variables-bug
michaelstaib 3204c9c
reworked
michaelstaib cac26b4
updated snapshots
michaelstaib File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
63 changes: 63 additions & 0 deletions
63
...e.Tests/__snapshots__/RequestPlannerTests.Query_Plan_25_Variables_Are_Passed_Through.snap
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,63 @@ | ||
UserRequest | ||
--------------- | ||
query Appointments($first: Int!) { | ||
patientById(patientId: 1) { | ||
name | ||
appointments(first: $first) { | ||
nodes { | ||
id | ||
} | ||
} | ||
} | ||
} | ||
--------------- | ||
|
||
QueryPlan | ||
--------------- | ||
{ | ||
"document": "query Appointments($first: Int!) { patientById(patientId: 1) { name appointments(first: $first) { nodes { id } } } }", | ||
"operation": "Appointments", | ||
"rootNode": { | ||
"type": "Sequence", | ||
"nodes": [ | ||
{ | ||
"type": "Resolve", | ||
"subgraph": "Patient1", | ||
"document": "query Appointments_1 { patientById(patientId: 1) { name __fusion_exports__1: id } }", | ||
"selectionSetId": 0 | ||
}, | ||
{ | ||
"type": "Compose", | ||
"selectionSetIds": [ | ||
0 | ||
] | ||
}, | ||
{ | ||
"type": "Resolve", | ||
"subgraph": "Appointment", | ||
"document": "query Appointments_2($__fusion_exports__1: ID!, $first: Int!) { node(id: $__fusion_exports__1) { ... on Patient1 { appointments(first: $first) { nodes { id } } } } }", | ||
"selectionSetId": 1, | ||
"path": [ | ||
"node" | ||
], | ||
"requires": [ | ||
{ | ||
"variable": "__fusion_exports__1" | ||
} | ||
], | ||
"forwardedVariables": [ | ||
{ | ||
"variable": "first" | ||
} | ||
] | ||
}, | ||
{ | ||
"type": "Compose", | ||
"selectionSetIds": [ | ||
1 | ||
] | ||
} | ||
] | ||
} | ||
} | ||
--------------- |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,8 +1,17 @@ | ||
using HotChocolate.Types; | ||
using HotChocolate.Types.Relay; | ||
|
||
namespace HotChocolate.Fusion.Shared.Appointments; | ||
|
||
public class Patient1 : IPatient | ||
{ | ||
[ID<Patient1>] public int Id { get; set;} | ||
|
||
[UsePaging] | ||
public IEnumerable<Appointment> Appointments => new List<Appointment>() | ||
{ | ||
new Appointment(), | ||
new Appointment(), | ||
new Appointment(), | ||
}; | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why an immutable dictionary. Those have bad lookup perf.