Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed issue with null value serialization when using GraphQL literals. #6357

Merged
merged 5 commits into from
Jul 19, 2023

Conversation

A360JMaxxgamer
Copy link
Collaborator

Null value variables e.g. for empty cursor, cannot be serialized as a string. That was the default case. Now NullValueNodes are handled correctly.

  • add NullValueNode case to WriteFieldValue method in Utf8JsonWriterHelper

@michaelstaib michaelstaib changed the title handle NullValueNode to fix serilization of null values Fixed issue with null value serialization when using GraphQL literals. Jul 19, 2023
@michaelstaib michaelstaib merged commit 89e65f0 into main Jul 19, 2023
@michaelstaib michaelstaib deleted the bugfix/nullvalue-serilization branch July 19, 2023 16:22
@sonarcloud
Copy link

sonarcloud bot commented Jul 19, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

This was referenced Sep 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants