Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix broken examples in dataloader.md #6372

Merged
merged 2 commits into from
Jul 21, 2023
Merged

Fix broken examples in dataloader.md #6372

merged 2 commits into from
Jul 21, 2023

Conversation

danpaul88
Copy link
Contributor

Summary of the changes (Less than 80 chars)

Closes #6371

@danpaul88
Fix broken examples in dataloader.md
fcc8358 
As of ChilliCream#4167 the `DataLoaderOptions` type no longer has a generic type parameter
@CLAassistant
Copy link

CLAassistant commented Jul 21, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot added the 📚 documentation This issue is about working on our documentation. label Jul 21, 2023
@michaelstaib
Copy link
Member

Thanks for your contributions.

@michaelstaib michaelstaib merged commit d890e61 into ChilliCream:main Jul 21, 2023
@danpaul88 danpaul88 deleted the docs-dataloader-fix branch July 21, 2023 10:33
@PascalSenn PascalSenn mentioned this pull request Aug 31, 2023
Merged
This was referenced Sep 10, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelstaib michaelstaib michaelstaib approved these changes

Assignees
No one assigned
Labels
📚 documentation This issue is about working on our documentation.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Documentation: DataLoader examples reference non-extant type DataLoaderOptions<T>
3 participants
@danpaul88 @CLAassistant @michaelstaib