-
-
Notifications
You must be signed in to change notification settings - Fork 748
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Scope the projection selection properly when using the mutation conventions. #6444
Scope the projection selection properly when using the mutation conventions. #6444
Conversation
This looks already good ... thanks for contributing... I will have a look at it later tonight. |
...tChocolate/Data/src/Data/Projections/Extensions/ProjectionObjectFieldDescriptorExtensions.cs
Outdated
Show resolved
Hide resolved
…onObjectFieldDescriptorExtensions.cs
...tChocolate/Data/src/Data/Projections/Extensions/ProjectionObjectFieldDescriptorExtensions.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks really good!
...tChocolate/Data/src/Data/Projections/Extensions/ProjectionObjectFieldDescriptorExtensions.cs
Outdated
Show resolved
Hide resolved
…onObjectFieldDescriptorExtensions.cs Co-authored-by: PascalSenn <senn.pasc@gmail.com>
...tChocolate/Data/src/Data/Projections/Extensions/ProjectionObjectFieldDescriptorExtensions.cs
Outdated
Show resolved
Hide resolved
25df444
to
9f921a8
Compare
…ection middleware to use an if else case for mutation convention fixes
...tChocolate/Data/src/Data/Projections/Extensions/ProjectionObjectFieldDescriptorExtensions.cs
Outdated
Show resolved
Hide resolved
@hahn-kev I did a couple more refinements ... but I think its good now. |
I created a new preview of 13.5 ... you can use it with the newest preview. |
Tested it out and it works exactly how I expected. Looking forward to the full release. I'll try and use it and let you know if we find issues. |
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [HotChocolate.Abstractions](https://chillicream.com/) ([source](https://github.com/ChilliCream/graphql-platform)) | nuget | minor | `13.4.0` -> `13.5.1` | | [HotChocolate.AspNetCore](https://chillicream.com/) ([source](https://github.com/ChilliCream/graphql-platform)) | nuget | minor | `13.4.0` -> `13.5.1` | | [HotChocolate.AspNetCore.Authorization](https://chillicream.com/) ([source](https://github.com/ChilliCream/graphql-platform)) | nuget | minor | `13.4.0` -> `13.5.1` | | [HotChocolate.Data](https://chillicream.com/) ([source](https://github.com/ChilliCream/graphql-platform)) | nuget | minor | `13.4.0` -> `13.5.1` | | [HotChocolate.Data.EntityFramework](https://chillicream.com/) ([source](https://github.com/ChilliCream/graphql-platform)) | nuget | minor | `13.4.0` -> `13.5.1` | | [HotChocolate.Types](https://chillicream.com/) ([source](https://github.com/ChilliCream/graphql-platform)) | nuget | minor | `13.4.0` -> `13.5.1` | --- ### Release Notes <details> <summary>ChilliCream/graphql-platform (HotChocolate.Abstractions)</summary> ### [`v13.5.1`](https://github.com/ChilliCream/graphql-platform/releases/tag/13.5.1) [Compare Source](https://github.com/ChilliCream/graphql-platform/compare/13.5.0...13.5.1) ##### What's Changed - StrawberryShake public access modifier must be default. by [@​michaelstaib](https://github.com/michaelstaib) in [https://github.com/ChilliCream/graphql-platform/pull/6472](https://github.com/ChilliCream/graphql-platform/pull/6472) **Full Changelog**: ChilliCream/graphql-platform@13.5.0...13.5.1 ### [`v13.5.0`](https://github.com/ChilliCream/graphql-platform/releases/tag/13.5.0) [Compare Source](https://github.com/ChilliCream/graphql-platform/compare/13.4.0...13.5.0) #### What's Changed - Added GraphQL Request Field Limit. by [@​michaelstaib](https://github.com/michaelstaib) in [https://github.com/ChilliCream/graphql-platform/pull/6381](https://github.com/ChilliCream/graphql-platform/pull/6381) - Fixed Subscription Complete Issue for ValueType Message. by [@​michaelstaib](https://github.com/michaelstaib) in [https://github.com/ChilliCream/graphql-platform/pull/6383](https://github.com/ChilliCream/graphql-platform/pull/6383) - Optimized the Type Module Source Generator by [@​michaelstaib](https://github.com/michaelstaib) in [https://github.com/ChilliCream/graphql-platform/pull/6388](https://github.com/ChilliCream/graphql-platform/pull/6388) - Adds postgres transport for subscriptions by [@​PascalSenn](https://github.com/PascalSenn) in [https://github.com/ChilliCream/graphql-platform/pull/6387](https://github.com/ChilliCream/graphql-platform/pull/6387) - Expose internals of Fusion to BCP services by [@​PascalSenn](https://github.com/PascalSenn) in [https://github.com/ChilliCream/graphql-platform/pull/6390](https://github.com/ChilliCream/graphql-platform/pull/6390) - Include .NET 8.0 tools in StrawberryShake package by [@​repne](https://github.com/repne) in [https://github.com/ChilliCream/graphql-platform/pull/6395](https://github.com/ChilliCream/graphql-platform/pull/6395) - Upgrade default BCP middleware version by [@​PascalSenn](https://github.com/PascalSenn) in [https://github.com/ChilliCream/graphql-platform/pull/6410](https://github.com/ChilliCream/graphql-platform/pull/6410) - Scope the projection selection properly when using the mutation conventions. by [@​hahn-kev](https://github.com/hahn-kev) in [https://github.com/ChilliCream/graphql-platform/pull/6444](https://github.com/ChilliCream/graphql-platform/pull/6444) - Reintroduce RequestContextAccessor by [@​michaelstaib](https://github.com/michaelstaib) in [https://github.com/ChilliCream/graphql-platform/pull/6454](https://github.com/ChilliCream/graphql-platform/pull/6454) - Publicly expose ability to register an error type on a mutation field by [@​benmccallum](https://github.com/benmccallum) in [https://github.com/ChilliCream/graphql-platform/pull/6463](https://github.com/ChilliCream/graphql-platform/pull/6463) - Removed Path Pooling by [@​michaelstaib](https://github.com/michaelstaib) in [https://github.com/ChilliCream/graphql-platform/pull/6394](https://github.com/ChilliCream/graphql-platform/pull/6394) - Fixed naming issues with generic types by [@​N-Olbert](https://github.com/N-Olbert) in [https://github.com/ChilliCream/graphql-platform/pull/6461](https://github.com/ChilliCream/graphql-platform/pull/6461) - Fixed Batch Pool for DataLoader was cleared to early. by [@​michaelstaib](https://github.com/michaelstaib) in [https://github.com/ChilliCream/graphql-platform/pull/6465](https://github.com/ChilliCream/graphql-platform/pull/6465) - Added configurable access for generated Strawberry Shake clients ([#​6374](https://github.com/ChilliCream/graphql-platform/issues/6374)) by [@​nih0n](https://github.com/nih0n) in [https://github.com/ChilliCream/graphql-platform/pull/6416](https://github.com/ChilliCream/graphql-platform/pull/6416) **Full Changelog**: ChilliCream/graphql-platform@13.4.0...13.5.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 10pm every weekday,every weekend,before 5am every weekday" in timezone Europe/Berlin, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/orso-co/Orso.Arpa.Api). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi44My4wIiwidXBkYXRlZEluVmVyIjoiMzYuODMuMCIsInRhcmdldEJyYW5jaCI6ImRldmVsb3AifQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Closes #5300