Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Batch Pool for DataLoader was cleared to early. #6465

Merged
merged 1 commit into from
Aug 21, 2023

Conversation

michaelstaib
Copy link
Member

Fixes #6464

@github-actions
Copy link

HotChocolate.Subscriptions.Postgres.BackgroundTaskTests.RunContinuously_Should_WaitForASecond_When_HandlerThrowsException [FAIL]

@github-actions
Copy link

HotChocolate.Execution.Integration.DataLoader.UseDataLoaderTests.UseDataLoader_Schema_GroupedDataloader_Single_Execute [FAIL]

@codecov
Copy link

codecov bot commented Aug 21, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.07% ⚠️

Comparison is base (a13fa04) 79.04% compared to head (e233644) 78.98%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6465      +/-   ##
==========================================
- Coverage   79.04%   78.98%   -0.07%     
==========================================
  Files        2911     2897      -14     
  Lines      139242   138641     -601     
==========================================
- Hits       110063   109499     -564     
+ Misses      29179    29142      -37     
Flag Coverage Δ
unittests 78.98% <100.00%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
src/GreenDonut/src/Core/DataLoaderBase.cs 90.04% <100.00%> (ø)

... and 28 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sonarcloud
Copy link

sonarcloud bot commented Aug 21, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@michaelstaib michaelstaib merged commit eb38b1b into main Aug 21, 2023
@michaelstaib michaelstaib deleted the mst/data-loader-batch-pooling branch August 21, 2023 12:46
@michaelstaib michaelstaib restored the mst/data-loader-batch-pooling branch August 21, 2023 13:04
This was referenced Sep 10, 2023
renovate bot referenced this pull request in orso-co/Orso.Arpa.Api Sep 16, 2023
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [HotChocolate.Abstractions](https://chillicream.com/)
([source](https://github.com/ChilliCream/graphql-platform)) | nuget |
minor | `13.4.0` -> `13.5.1` |
| [HotChocolate.AspNetCore](https://chillicream.com/)
([source](https://github.com/ChilliCream/graphql-platform)) | nuget |
minor | `13.4.0` -> `13.5.1` |
| [HotChocolate.AspNetCore.Authorization](https://chillicream.com/)
([source](https://github.com/ChilliCream/graphql-platform)) | nuget |
minor | `13.4.0` -> `13.5.1` |
| [HotChocolate.Data](https://chillicream.com/)
([source](https://github.com/ChilliCream/graphql-platform)) | nuget |
minor | `13.4.0` -> `13.5.1` |
| [HotChocolate.Data.EntityFramework](https://chillicream.com/)
([source](https://github.com/ChilliCream/graphql-platform)) | nuget |
minor | `13.4.0` -> `13.5.1` |
| [HotChocolate.Types](https://chillicream.com/)
([source](https://github.com/ChilliCream/graphql-platform)) | nuget |
minor | `13.4.0` -> `13.5.1` |

---

### Release Notes

<details>
<summary>ChilliCream/graphql-platform
(HotChocolate.Abstractions)</summary>

###
[`v13.5.1`](https://github.com/ChilliCream/graphql-platform/releases/tag/13.5.1)

[Compare
Source](https://github.com/ChilliCream/graphql-platform/compare/13.5.0...13.5.1)

##### What's Changed

- StrawberryShake public access modifier must be default. by
[@&#8203;michaelstaib](https://github.com/michaelstaib) in
[https://github.com/ChilliCream/graphql-platform/pull/6472](https://github.com/ChilliCream/graphql-platform/pull/6472)

**Full Changelog**:
ChilliCream/graphql-platform@13.5.0...13.5.1

###
[`v13.5.0`](https://github.com/ChilliCream/graphql-platform/releases/tag/13.5.0)

[Compare
Source](https://github.com/ChilliCream/graphql-platform/compare/13.4.0...13.5.0)

#### What's Changed

- Added GraphQL Request Field Limit. by
[@&#8203;michaelstaib](https://github.com/michaelstaib) in
[https://github.com/ChilliCream/graphql-platform/pull/6381](https://github.com/ChilliCream/graphql-platform/pull/6381)
- Fixed Subscription Complete Issue for ValueType Message. by
[@&#8203;michaelstaib](https://github.com/michaelstaib) in
[https://github.com/ChilliCream/graphql-platform/pull/6383](https://github.com/ChilliCream/graphql-platform/pull/6383)
- Optimized the Type Module Source Generator by
[@&#8203;michaelstaib](https://github.com/michaelstaib) in
[https://github.com/ChilliCream/graphql-platform/pull/6388](https://github.com/ChilliCream/graphql-platform/pull/6388)
- Adds postgres transport for subscriptions by
[@&#8203;PascalSenn](https://github.com/PascalSenn) in
[https://github.com/ChilliCream/graphql-platform/pull/6387](https://github.com/ChilliCream/graphql-platform/pull/6387)
- Expose internals of Fusion to BCP services by
[@&#8203;PascalSenn](https://github.com/PascalSenn) in
[https://github.com/ChilliCream/graphql-platform/pull/6390](https://github.com/ChilliCream/graphql-platform/pull/6390)
- Include .NET 8.0 tools in StrawberryShake package by
[@&#8203;repne](https://github.com/repne) in
[https://github.com/ChilliCream/graphql-platform/pull/6395](https://github.com/ChilliCream/graphql-platform/pull/6395)
- Upgrade default BCP middleware version by
[@&#8203;PascalSenn](https://github.com/PascalSenn) in
[https://github.com/ChilliCream/graphql-platform/pull/6410](https://github.com/ChilliCream/graphql-platform/pull/6410)
- Scope the projection selection properly when using the mutation
conventions. by [@&#8203;hahn-kev](https://github.com/hahn-kev) in
[https://github.com/ChilliCream/graphql-platform/pull/6444](https://github.com/ChilliCream/graphql-platform/pull/6444)
- Reintroduce RequestContextAccessor by
[@&#8203;michaelstaib](https://github.com/michaelstaib) in
[https://github.com/ChilliCream/graphql-platform/pull/6454](https://github.com/ChilliCream/graphql-platform/pull/6454)
- Publicly expose ability to register an error type on a mutation field
by [@&#8203;benmccallum](https://github.com/benmccallum) in
[https://github.com/ChilliCream/graphql-platform/pull/6463](https://github.com/ChilliCream/graphql-platform/pull/6463)
- Removed Path Pooling by
[@&#8203;michaelstaib](https://github.com/michaelstaib) in
[https://github.com/ChilliCream/graphql-platform/pull/6394](https://github.com/ChilliCream/graphql-platform/pull/6394)
- Fixed naming issues with generic types by
[@&#8203;N-Olbert](https://github.com/N-Olbert) in
[https://github.com/ChilliCream/graphql-platform/pull/6461](https://github.com/ChilliCream/graphql-platform/pull/6461)
- Fixed Batch Pool for DataLoader was cleared to early. by
[@&#8203;michaelstaib](https://github.com/michaelstaib) in
[https://github.com/ChilliCream/graphql-platform/pull/6465](https://github.com/ChilliCream/graphql-platform/pull/6465)
- Added configurable access for generated Strawberry Shake clients
([#&#8203;6374](https://github.com/ChilliCream/graphql-platform/issues/6374))
by [@&#8203;nih0n](https://github.com/nih0n) in
[https://github.com/ChilliCream/graphql-platform/pull/6416](https://github.com/ChilliCream/graphql-platform/pull/6416)

**Full Changelog**:
ChilliCream/graphql-platform@13.4.0...13.5.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "after 10pm every weekday,every
weekend,before 5am every weekday" in timezone Europe/Berlin, Automerge -
At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about these
updates again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/orso-co/Orso.Arpa.Api).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi44My4wIiwidXBkYXRlZEluVmVyIjoiMzYuODMuMCIsInRhcmdldEJyYW5jaCI6ImRldmVsb3AifQ==-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Data reported by OpenTelemetry for BatchLoader is incorrect
1 participant