Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed multiline descriptions #6789

Merged
merged 9 commits into from
Dec 22, 2023
Merged

Fixed multiline descriptions #6789

merged 9 commits into from
Dec 22, 2023

Conversation

tobias-tengler
Copy link
Collaborator

Fixes #5561

Copy link

github-actions bot commented Dec 21, 2023

Qodana for .NET

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at qodana-support@jetbrains.com

Copy link

codecov bot commented Dec 21, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (7333e63) 70.89% compared to head (b3d5b81) 70.99%.

Files Patch % Lines
...immed/src/Skimmed/Serialization/SchemaFormatter.cs 85.71% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6789      +/-   ##
==========================================
+ Coverage   70.89%   70.99%   +0.10%     
==========================================
  Files        2520     2534      +14     
  Lines      126574   127210     +636     
==========================================
+ Hits        89730    90311     +581     
- Misses      36844    36899      +55     
Flag Coverage Δ
unittests 70.99% <86.36%> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tobias-tengler tobias-tengler added the 👓 ready-for-review The PR is ready for review. label Dec 21, 2023
Copy link

sonarcloud bot commented Dec 22, 2023

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@michaelstaib michaelstaib changed the title [Core / Fusion] Fix multiline descriptions Fixed multiline descriptions Dec 22, 2023
@michaelstaib michaelstaib merged commit cbcb4b5 into main Dec 22, 2023
92 of 99 checks passed
@michaelstaib michaelstaib deleted the tte/fix-multiline-comments branch December 22, 2023 09:15
@PascalSenn PascalSenn mentioned this pull request Feb 19, 2024
@PascalSenn PascalSenn mentioned this pull request May 22, 2024
@PascalSenn PascalSenn mentioned this pull request Jun 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants