Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Keyed Service Attribute #6810

Merged
merged 4 commits into from
Jan 11, 2024
Merged

Conversation

michaelstaib
Copy link
Member

No description provided.

Copy link

codecov bot commented Jan 10, 2024

Codecov Report

Attention: 11 lines in your changes are missing coverage. Please review.

Comparison is base (e4cb074) 70.92% compared to head (6512fe9) 73.71%.

❗ Current head 6512fe9 differs from pull request most recent head 5594351. Consider uploading reports for the commit 5594351 to get more accurate results

Files Patch % Lines
...ameters/ScopedServiceParameterExpressionBuilder.cs 0.00% 6 Missing ⚠️
.../Expressions/Parameters/ServiceExpressionHelper.cs 91.48% 4 Missing ⚠️
...ns/Parameters/ServiceParameterExpressionBuilder.cs 83.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6810      +/-   ##
==========================================
+ Coverage   70.92%   73.71%   +2.78%     
==========================================
  Files        2520     2534      +14     
  Lines      126600   127236     +636     
==========================================
+ Hits        89792    93788    +3996     
+ Misses      36808    33448    -3360     
Flag Coverage Δ
unittests 73.71% <81.66%> (+2.78%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@michaelstaib michaelstaib merged commit 0a2e0fc into main Jan 11, 2024
2 of 3 checks passed
@michaelstaib michaelstaib deleted the mst/keyed-services-attribute branch January 11, 2024 15:50
Copy link

sonarcloud bot commented Jan 11, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant