-
-
Notifications
You must be signed in to change notification settings - Fork 748
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fusion] Fixed duplicated selections #7677
Conversation
Just noticed another issue that has also existed previously: Selections on interfaces are inlined into object type selections, but not explicitly forwarded to subgraphs. Original query: communityItems(first: 3) {
nodes {
__typename
... on CommunityDiscussion {
databaseId
}
... on ProductQuestion {
databaseId
}
... on ProductReview {
databaseId
}
... on Node {
__isNode: __typename
id
}
}
} Subgraph query: communityItems(first: 3) {
nodes {
__typename
... on CommunityDiscussion {
__typename
databaseId
__isNode: __typename
id
}
... on ProductQuestion {
__typename
databaseId
__isNode: __typename
id
}
... on ProductReview {
__typename
databaseId
__isNode: __typename
id
}
}
} |
573fc08
to
a11adb9
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7677 +/- ##
==========================================
+ Coverage 73.95% 74.00% +0.05%
==========================================
Files 2917 2918 +1
Lines 151116 151252 +136
Branches 17560 17576 +16
==========================================
+ Hits 111753 111936 +183
+ Misses 33507 33465 -42
+ Partials 5856 5851 -5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Fixes #7687