@semanticNonNull support #7681
Merged
@semanticNonNull support #7681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tobias-tengler
force-pushed
the
tte/hotchocolate-semantic-non-null
branch
from
79ec25d to
1f766a2
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7681 +/- ##
==========================================
+ Coverage 74.00% 74.03% +0.02%
==========================================
Files 2918 2920 +2
Lines 151252 151490 +238
Branches 17576 17618 +42
==========================================
+ Hits 111936 112152 +216
- Misses 33464 33485 +21
- Partials 5852 5853 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
glen-84
reviewed
Nov 5, 2024
glen-84
reviewed
Nov 5, 2024
tobias-tengler
force-pushed
the
tte/hotchocolate-semantic-non-null
branch
from
6a2d95e to
7344282
Compare
tobias-tengler
force-pushed
the
tte/hotchocolate-semantic-non-null
branch
from
7344282 to
83e7547
Compare
tobias-tengler
changed the title
tobias-tengler
force-pushed
the
tte/hotchocolate-semantic-non-null
branch
from
c86300f to
aca4e59
Compare
tobias-tengler
commented
Nov 14, 2024
Comment on lines
+938
to
+944
| public string[] PureScalarListItemThrowingError(IResolverContext context) | ||
| { | ||
| // TODO: How can you create a terminating error for a single item? | ||
| context.ReportError(ErrorBuilder.New().SetMessage("Another error").SetPath(context.Path.Append(1)).Build()); | ||
| return ["a", null!, "c"]; | ||
| } |
There was a problem hiding this comment.
Does someone have an idea?
tobias-tengler
force-pushed
the
tte/hotchocolate-semantic-non-null
branch
from
aca4e59 to
20a18cb
Compare
src/HotChocolate/Core/src/Types/Configuration/TypeInitializer.cs
Outdated
Show resolved
Hide resolved
src/HotChocolate/Core/src/Types/SemanticNonNullTypeInterceptor.cs
Outdated
Show resolved
Hide resolved
michaelstaib
pushed a commit
that referenced
this pull request
Nov 19, 2024
tobias-tengler
added
the
🍒 cherry-pick
tobias-tengler
added a commit
that referenced
this pull request
Nov 28, 2024
michaelstaib
pushed a commit
that referenced
this pull request
Nov 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new
EnableSemanticNonNulloption that, when set totrue, rewrites all non-null fields to nullable fields and annotates them with the@semanticNonNulldirective. A ResultFormatter is added to the rewritten fields that throws an error if anullvalue is returned at a position that is marked as semantically non-null.The
@semanticNonNulldirective has alevelsargument that allows to specify the semantic non-nullability in the context of lists.0is the outer most list and n the named type.field: String!field: String @semanticNonNullfield: [String!]field: [String] @semanticNonNull(levels: [ 1 ])field: [[String!]]!field: [[String]] @semanticNonNull(levels: [ 0, 2 ])