Fixed client complete aborting websocket that is sending #7793
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ManagedWebSocket.SendAsync abort the connection when a cancellation is raised. OperationSession cancel reading the response stream and sending when the client sends a complete message. This PR fixes multiple operation being aborted by a completing operation.
sunghwan2789
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7793 +/- ##
==========================================
- Coverage 74.33% 74.32% -0.01%
==========================================
Files 2867 2867
Lines 149872 149872
Branches 17414 17414
==========================================
- Hits 111411 111398 -13
- Misses 32658 32673 +15
+ Partials 5803 5801 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
michaelstaib
pushed a commit
that referenced
this pull request
Dec 3, 2024
michaelstaib
added
the
🍒 cherry-pick
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ManagedWebSocket.SendAsyncabort the connection when a cancellation is raised.OperationSessioncancel reading the response stream and sending when the client sends a complete message. This PR fixes multiple operation being aborted by a completing operation.https://github.com/dotnet/runtime/blob/e7d837da5b1aacd9325a8b8f2214cfaf4d3f0ff6/src/libraries/System.Net.WebSockets/src/System/Net/WebSockets/ManagedWebSocket.cs#L613