Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added "AddDataLoader<TService, TImplementation>" executor overload that takes a factory #7803

Merged

Conversation

danielreynolds1
Copy link
Collaborator

Summary of the changes (Less than 80 chars)

Adds an executor overload for dataloaders that allows an implementation factory to be provided

@danielreynolds1 danielreynolds1 added the 👓 ready-for-review The PR is ready for review. label Dec 3, 2024
Copy link

codecov bot commented Dec 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.35%. Comparing base (b669e1f) to head (d4c3592).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7803      +/-   ##
==========================================
+ Coverage   74.33%   74.35%   +0.01%     
==========================================
  Files        2870     2870              
  Lines      149897   149903       +6     
  Branches    17416    17418       +2     
==========================================
+ Hits       111421   111455      +34     
+ Misses      32673    32647      -26     
+ Partials     5803     5801       -2     
Flag Coverage Δ
unittests 74.35% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@michaelstaib michaelstaib merged commit 1b0e798 into ChilliCream:main Dec 3, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants