Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support to HTML #23

Merged
merged 4 commits into from
Nov 22, 2024
Merged

Conversation

unnamedd
Copy link
Contributor

@unnamedd unnamedd commented Nov 21, 2024

Description

Add support to HTML

To Do

  • Find and fix the rendering problem that occurs when an HTML file is opened

Screenshots of the problem

image

This PR checks one item in the todo list of the issue #20.

@unnamedd unnamedd changed the title Languages/html support Add support to HTML Nov 21, 2024
@unnamedd unnamedd marked this pull request as draft November 21, 2024 20:23
@mattmassicotte
Copy link
Contributor

Ok I had a suspicion and it turns out to be correct. NSTextStorage supports a bunch of loading options, and one controls how it interprets known document types. The fix ended up being really easy!

I also removed the addition to the imported UTIs. This is only necessary for UTIs that are not built in. Have to update the documentation.

@unnamedd
Copy link
Contributor Author

Awesome! Thanks for the research and for removing the extra addition on Info.plist.

@unnamedd unnamedd marked this pull request as ready for review November 22, 2024 14:24
@unnamedd
Copy link
Contributor Author

@mattmassicotte because of your fix, everything seems ok to be moved on.
Now the PR is ready for you review/merge.

image

@mattmassicotte
Copy link
Contributor

Yeah we can revisit the highlighting quality later. That's almost certainly due to poor tree-sitter query definitions.

@mattmassicotte mattmassicotte merged commit 2606ec3 into ChimeHQ:main Nov 22, 2024
1 of 2 checks passed
@unnamedd unnamedd deleted the Languages/HTML-Support branch November 22, 2024 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants