fix: getAuditInstancesInfoFromStudyUID not handle empty studyUID

- Handle empty studyUID in getAuditInstancesInfoFromStudyUID function to prevent unnecessary database query.
Chinlinlee · Nov 18, 2023 · 6b667a2 · 6b667a2
1 parent 90def2d
commit 6b667a2
Showing 1 changed file with 7 additions and 6 deletions.
diff --git a/models/sql/models/instance.model.js b/models/sql/models/instance.model.js
@@ -37,18 +37,19 @@ class InstanceModel extends Model {
      * @param {string} studyUID 
      */
     static async getAuditInstancesInfoFromStudyUID(studyUID) {
-        let instances = await sequelizeInstance.model("Instance").findAll({
-            where: {
-                x0020000D: studyUID
-            }
-        });
-
         let instanceInfos = {
             sopClassUIDs: [],
             accessionNumbers: [],
             patientID: "",
             patientName: ""
         };
+        if (!studyUID) return instanceInfos;
+
+        let instances = await sequelizeInstance.model("Instance").findAll({
+            where: {
+                x0020000D: studyUID
+            }
+        });
 
         for (let instance of instances) {
             let sopClassUID = instance.x00080016;