Fix Uglify not minifying js-ipfs libraries #28
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP
I think the best way to approach this is ejecting and using an updated version of uglify that can handle es6 code. This is because js-ipfs libs don't transpile code and webpack ends up importing es6 code that uglify can't handle.
Another way is manually making a list of packages that have to go through babel before reaching webpack but this means we still have to eject and also if js-ipfs deps change it could break our build.
As of right now, I ejected and changed webpack configuration to use an update uglifyjs. I also disabled compression and mangling because one of them or both were causing issues in the build. I need to further investigate what is the problem so that we can get the most optimized result without issues