Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Form validation and Chlu reviews #52

Merged
merged 11 commits into from
Feb 27, 2018
Merged

Form validation and Chlu reviews #52

merged 11 commits into from
Feb 27, 2018

Conversation

fazo96
Copy link
Collaborator

@fazo96 fazo96 commented Feb 20, 2018

PR Content:

@fazo96 fazo96 self-assigned this Feb 20, 2018
@fazo96
Copy link
Collaborator Author

fazo96 commented Feb 23, 2018

I removed all test data regarding reviews in chlu-demo, instead now real reviews show up in all the screens (Vendor Profile, Vendor Wallet, Customer Transactions).

Customers can also update a review if they have the right orbitDb key in the localstorage, in that case the Edit button shows up and the review text and star rating can be changed

When a review is edited, the actuall call is performed through ChluIPFS so the review gets updated for real!

Also, when the demo reads reviews it checks for updates and when they arrive the review data in the redux store gets updated automatically

All of this needs a little cleanup, more testing and there are some changes we should make to ChluIPFS to improve how this works (ref: ChluNetwork/chlu-ipfs-support#46), I think the developer experience of using ChluIPFS needs to be better.

@fazo96 fazo96 requested a review from kulpreet February 26, 2018 11:25
@fazo96 fazo96 changed the title [WIP] Form validation and Chlu reviews Form validation and Chlu reviews Feb 26, 2018
@fazo96 fazo96 mentioned this pull request Feb 26, 2018
@kulpreet kulpreet merged commit d89e853 into master Feb 27, 2018
@fazo96 fazo96 deleted the form-validation branch April 17, 2018 09:08
@fazo96 fazo96 restored the form-validation branch April 17, 2018 09:09
@fazo96 fazo96 deleted the form-validation branch April 17, 2018 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants