Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle multiple upgrades for the same height in chain provider #13

Merged
merged 2 commits into from
Nov 9, 2024

Conversation

mkaczanowski
Copy link
Contributor

TL;DR

Onchain governance allows a user to register multiple software upgrade proposals for the same height.
Blazar however needs to find the upgrade that will get executed, or is most likely to be executed at given height.

The selection process is quite simple (if there are more than one upgrade proposal per height):

  1. if upgrade PASSED, use it
  2. if there are multiple PASSED (unlikely), use the one with higher proposal ID
  3. if no upgrade PASSED use the one with higher proposal ID (likely, a user wanted to "override" the older one)

@mkaczanowski mkaczanowski merged commit 346a976 into main Nov 9, 2024
2 checks passed
@sin3point14 sin3point14 deleted the fix_duplicated_upgrades_in_chain_provider branch November 9, 2024 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants