support governance type upgrades from non chain providers #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Some chains like Neutron implement their own governance, which Blazar doesn't support. Therefore Blazar can't see the upgrade, and will never execute it.
However, because Neutron governance is compatible with
upgradescosmos sdk module, at the upgrade height the 'upgrade-info.json` is created. Therefore from a chain perspective, the governance works as expected.To make Blazar work in this scenario, a user can register a
GOVERNANCEtype upgrade inLOCALorDATABASEprovider.This PR makes this possible.
NOTE: This is slightly modified PR from @sin3point14 (https://github.com/ChorusOne/blazar/pull/9/files) - I am only merging this
Test plan
unittests + integration tests