Remove blazar_upgrade_step metric and add validator_address, chain_id labels to blazar_blocks_to_upgrade_height #27
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
blazar_upgrade_step
metric isn't human friendly since it exports upgraded step as an integer, one needs to lookup the proto to understand what the integers mean. Hence this PR removes that metric and instead addsupgrade_state
andupgade_step
as labels to theblazar_blocks_to_upgrade_height
metric.This also adds a
validator_address
label which is set to.valdiator_info.address
from the/status
tendermint endpoint andchain_id
which is set tonode_info.network
from the same endpoint.So now the metric looks like:
This metric along with the new labels will be useful in our case to suppress alerts when we know that an upgrade is under progress.
Test plan
We don't have any tests for metrics so I ran blazar on a dummy node and it seems to work fine. The sample metric above were fetched from that machine.