Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove blazar_upgrade_step metric and add validator_address, chain_id labels to blazar_blocks_to_upgrade_height #27

Merged
merged 6 commits into from
Dec 17, 2024

Conversation

sin3point14
Copy link
Contributor

@sin3point14 sin3point14 commented Dec 11, 2024

The blazar_upgrade_step metric isn't human friendly since it exports upgraded step as an integer, one needs to lookup the proto to understand what the integers mean. Hence this PR removes that metric and instead adds upgrade_state and upgade_step as labels to the blazar_blocks_to_upgrade_height metric.

This also adds a validator_address label which is set to .valdiator_info.address from the /status tendermint endpoint and chain_id which is set to node_info.network from the same endpoint.

So now the metric looks like:

blazar_blocks_to_upgrade_height{chain_id="dimension_37-1",compose_file="...",hostname="...",upgrade_height="12038821",upgrade_name="test-metrics-labels-manas",upgrade_status="ACTIVE",upgrade_step="MONITORING",validator_address="CA7978B0C8D1968449053DA54166A8DA6A8DC67E",version="devel"} 1410

This metric along with the new labels will be useful in our case to suppress alerts when we know that an upgrade is under progress.

Test plan

We don't have any tests for metrics so I ran blazar on a dummy node and it seems to work fine. The sample metric above were fetched from that machine.

@sin3point14 sin3point14 changed the title Add validator_address to a few metrics labels Add validator_address and chain_id to a few metrics labels Dec 12, 2024
@sin3point14 sin3point14 changed the title Add validator_address and chain_id to a few metrics labels Remove blazar_upgrade_status metric and add validator_address and chain_id to blocks_to_upgrade_height Dec 12, 2024
@sin3point14 sin3point14 changed the title Remove blazar_upgrade_status metric and add validator_address and chain_id to blocks_to_upgrade_height Remove blazar_upgrade_status metric and add validator_address, chain_id labels to blocks_to_upgrade_height Dec 12, 2024
@sin3point14 sin3point14 changed the title Remove blazar_upgrade_status metric and add validator_address, chain_id labels to blocks_to_upgrade_height Remove blazar_upgrade_step metric and add validator_address, chain_id labels to blocks_to_upgrade_height Dec 12, 2024
@sin3point14 sin3point14 changed the title Remove blazar_upgrade_step metric and add validator_address, chain_id labels to blocks_to_upgrade_height Remove blazar_upgrade_step metric and add validator_address, chain_id labels to blazar_blocks_to_upgrade_height Dec 12, 2024
@sin3point14 sin3point14 force-pushed the add-validator-address-label branch from 59e8f57 to bb2e0b3 Compare December 12, 2024 09:07
@DavidVentura DavidVentura self-requested a review December 17, 2024 08:48
@sin3point14 sin3point14 merged commit 6c74975 into main Dec 17, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants