Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate to Clap 4.x #50

Merged
merged 1 commit into from
Aug 8, 2024
Merged

Migrate to Clap 4.x #50

merged 1 commit into from
Aug 8, 2024

Conversation

mksh
Copy link
Contributor

@mksh mksh commented Aug 7, 2024 •
edited
Loading

This upgrades Clap, allowing for easier implementation of more UX changes for the CLI.

  • Upgrade Clap and CLI modules using it
  • Upgrade some auxiliary packages
  • Migrate some magic string based logic to enums
  • Upgrade cargo-deny to a version that disallows unlicensed
  • Explicitly forbid unsafe code

@mksh mksh mentioned this pull request Aug 7, 2024
Closed
@mksh mksh requested review from jenpaff, mikalsande and QAston August 7, 2024 00:26
@mksh mksh marked this pull request as ready for review August 7, 2024 00:27
jenpaff
jenpaff approved these changes Aug 8, 2024
View reviewed changes
Copy link
Contributor

@jenpaff jenpaff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank a lot for the upgrade & refactoring

@mksh mksh merged commit 1069258 into main Aug 8, 2024
2 checks passed
@mksh mksh deleted the clap4 branch August 8, 2024 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jenpaff jenpaff jenpaff approved these changes

@mikalsande mikalsande Awaiting requested review from mikalsande

@QAston QAston Awaiting requested review from QAston

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mksh @jenpaff