[STACKED] Command to generate presigned exit message #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mksh
changed the title
jenpaff
reviewed
Aug 22, 2024
| ### Command to send SignedBLSToExecutionChange request to Beacon node | ||
|
|
||
| ``` | ||
| curl -H "Content-Type: application/json" -d '{ |
There was a problem hiding this comment.
why are we showing curl command instead of cli cmd?
There was a problem hiding this comment.
The command right now does not support sending output to beacon node; it should be easy to add though given openssl-sys is already a dependency. I will do it in #54 as this PR only touches presigned exit message, but bls-to-execution-change
There was a problem hiding this comment.
Sending to beacon node was implemented in 64ef067
jenpaff
reviewed
Aug 22, 2024
README.md
Outdated
| ./target/debug/eth-staking-smith presigned-exit-message --chain mainnet --mnemonic "entire habit bottom mention spoil clown finger wheat motion fox axis mechanic country make garment bar blind stadium sugar water scissors canyon often ketchup" --validator_start_index 0 --validator_index 100 --epoch 300000 | ||
| ``` | ||
|
|
||
| Note that --validator-index and --validator-start-index are two distinct parameter, the former being index of validator on Beacon chain, and the latter is the index of validator private key derived from the seed |
There was a problem hiding this comment.
hm can we not just rename them to make it more explicit? --validator-beacon-index or --validator_seed_index
There was a problem hiding this comment.
Thanks, renamed in 176cfba, will rename in bls-to-execution-change in nested PR
jenpaff
approved these changes
Aug 22, 2024
mksh
added a commit
that referenced
this pull request
Aug 23, 2024
…t-message (#54) * Make bls-to-execution-change command work * [STACKED] Command to generate presigned exit message (#55) * Command to generate presigned exit message * Docs for presigned-exit-message * Code review feedback * Add support for sending signed payloads to beacon node * Add note on backwards compatibility policy * Unify regex usage * Adjustments for single payload cmds - Fix presigned-exit-message format & beacon node sending - Rename Operator traits -> validator - Rename operator module -> operations * Fix README
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on cleanup/refactor introduced in #54, create command to generate presigned exit message based on existing mnemonic