Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow mnemonic as env var #60

Merged
merged 3 commits into from
Oct 29, 2024
Merged

Allow mnemonic as env var #60

merged 3 commits into from
Oct 29, 2024

Conversation

mariavarvaroi
Copy link
Contributor

Add support for providing mnemonic phrases via MNEMONIC environment variable, for improved security.

Users can now either:

  • Set MNEMONIC environment variable (recommended): Keeps sensitive mnemonic phrases out of shell history
  • Use --mnemonic CLI argument as before

@mariavarvaroi mariavarvaroi requested a review from mksh October 29, 2024 13:26
mksh
mksh approved these changes Oct 29, 2024
View reviewed changes
Copy link
Contributor

@mksh mksh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mariavarvaroi mariavarvaroi force-pushed the allow_mnemonic_as_env_var branch from 74d69c4 to 9dea02e Compare October 29, 2024 13:34
@mariavarvaroi mariavarvaroi merged commit 4a9cc16 into main Oct 29, 2024
2 checks passed
@mariavarvaroi mariavarvaroi deleted the allow_mnemonic_as_env_var branch October 29, 2024 13:55
@mariavarvaroi mariavarvaroi mentioned this pull request Oct 29, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mksh mksh mksh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mariavarvaroi @mksh