Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Python version substitution per @Czaki #2

Closed
wants to merge 6 commits into from

Conversation

psobolewskiPhD
Copy link

Description

Hi, here I'm adding python_version as a substitution, per @Czaki comment:
#1 (comment)
(and the followup).
To make it work, I needed to also add a substitution for python={python_version} and the conda env instruction.
image

You can check out the built docs in my fork:
https://github.com/psobolewskiPhD/napari-docs/actions/runs/3624911741

I also fixed the listing of supported python versions from 3.7 ... to 3.8 ... because we don't support 3.7 anymore.

Type of change

  • Bug-fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

References

How has this been tested?

  • example: the test suite for my feature covers cases x, y, and z
  • example: all tests pass with my change

Final checklist:

  • My PR is the minimum possible work for the desired functionality
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • If I included new strings, I have used trans. to make them localizable.
    For more information see our translations guide.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant