Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added duplicate search notice #789

Merged
merged 2 commits into from
Dec 25, 2021
Merged

Added duplicate search notice #789

merged 2 commits into from
Dec 25, 2021

Conversation

goyalyashpal
Copy link
Contributor

No description provided.

Copy link

@just-a-hriday just-a-hriday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd suggest you use "you" instead of "u". Also, remove the "Hi,".

@goyalyashpal
Copy link
Contributor Author

I guess Hi sets the tone to a bit more casual. are u sure about removing that?

@goyalyashpal goyalyashpal marked this pull request as draft September 6, 2021 15:01
@goyalyashpal
Copy link
Contributor Author

have corrected the typo in u and missing apostrophe as well. Waiting for confirmation about removal of hi. Feel free to mark it as ready (i dont know if the maintainers can do that or it's only author who can do it) if no further changes are required.

@goyalyashpal goyalyashpal marked this pull request as ready for review September 17, 2021 13:38
@goyalyashpal
Copy link
Contributor Author

hi @ChrisAnd1998 umh, so, what does the closure mean??

@ChrisAnd1998 ChrisAnd1998 reopened this Dec 25, 2021
@ChrisAnd1998
Copy link
Owner

Sorry should not have been closed. Looking into this right now..

@ChrisAnd1998 ChrisAnd1998 reopened this Dec 25, 2021
@ChrisAnd1998 ChrisAnd1998 merged commit fcb815c into ChrisAnd1998:master Dec 25, 2021
@goyalyashpal goyalyashpal deleted the patch-1 branch December 25, 2021 13:13
@ChrisAnd1998
Copy link
Owner

@yashpalgoyal1304 Thank you! Sorry for the late response on this!
You may noticed all issues got closed. There where so many old, duplicate and already fixed issues that I didn't know what needs fixing anymore. So from here on we start fresh. People can still reopen the issue if the issue still persists after todays update.

@ChrisAnd1998
Copy link
Owner

@yashpalgoyal1304 Also updated #108 ;)

@goyalyashpal
Copy link
Contributor Author

goyalyashpal commented Dec 25, 2021

thanks for update, yep, i can understand that.

  • the duplicate issues can be a frustration to deal with....
  • i wish i had shared the version i was using in my issues (mostly new feature requests) 😅 but anyways....
    Update: considering many factors (like content, and timeframe of my comments), i am pretty sure it was version 1.7.2.0
  • also, since my issues were (radically) new feature requests, i dont think i will feel comfortable reopening those....
    (uhh, i dont know, am feeling a bit out of senses...)

@ChrisAnd1998
Copy link
Owner

Well all feature requests will be listed here: #870
Still need to clean that up.. But as you can see the list is big.
The problem is that I need all bugs out first before adding new features because new features always come with new bugs. 😅

@goyalyashpal
Copy link
Contributor Author

hi, so, one more question: how did u make that list??
i mean, it cant be made totally manual i guess, so, what app etc did u use to get that list? to automate/ease some part of the process.... i hope this question makes sense

@ChrisAnd1998
Copy link
Owner

ChrisAnd1998 commented Dec 25, 2021

@yashpalgoyal1304 Actually I did it all manually XD. If a new one comes I can just add it to the list. That's not too big of a deal but perhaps GitHub has an API for this..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants