Builder pattern for Client initialization #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -3,7 +3,7 @@ extern crate hashicorp_vault as vault; | |||
| fn main() { | |||
| let host = "http://localhost:8200"; | |||
| let token = "test12345"; | |||
| let client = vault::Client::new(host, token).unwrap(); | |||
| let client: vault::Client<()> = vault::Client::new(host).token(token).build().unwrap(); | |||
There was a problem hiding this comment.
I'm quite frustrated with this change requiring specifying the T for the VaultClient
ChrisMacNaughton
force-pushed
the
feature/builder-initializer
branch
4 times, most recently
from
1e08b33
to
56dfce5
Compare
ChrisMacNaughton
force-pushed
the
feature/builder-initializer
branch
from
56dfce5
to
fc3647b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.