Move Launch Issues from ReadMe to Known Issues #2222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MyDrift-user
changed the title
ChrisTitusTech
approved these changes
Jun 29, 2024
|
Looks Good |
|
Thanks, I moved the "Script doesn't run/PowerShell crashes" that caused the merge conflicts to the first section because it also has to do with the launch, it is mentioned two times now in the known issues |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the time there are two Titles named Issues, to minimize confusion and properly use Known Issues for known Issues i moved that part to the file and referenced it directly under the launch command.
In addition i fixed the link in the command:
[Net.ServicePointManager]::SecurityProtocol=[Net.SecurityProtocolType]::Tls12;iex(New-Object Net.WebClient).DownloadString('https://raw.githubusercontent.com/ChrisTitusTech/winutil/main/winutil.ps1')to use the link of the latest release instead of the winutil file in the repo folder:
[Net.ServicePointManager]::SecurityProtocol=[Net.SecurityProtocolType]::Tls12;iex(New-Object Net.WebClient).DownloadString('https://github.com/ChrisTitusTech/winutil/releases/latest/download/winutil.ps1')I also moved an Issue that has to do with running the script to that section and titles it "Launch Issues"
If this PR does not get accepted I will make another one only fixing the mentioned link.