-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI/CD] WIP: Re-use Workflows to Ensure GitHub Pages is built after every pre-release - Cleanup Workflow Naming Inconsistency - Remove 'release.yaml' workflow #2471
Conversation
…rrent branch Current branch means the running git branch that the GitHub Action was ran at.
1656a89
to
3f66851
Compare
77da72d
to
2d95b12
Compare
e710423
to
78e1487
Compare
78e1487
to
6c5c869
Compare
58986e9
to
753d9f9
Compare
822a92d
to
0d12b0c
Compare
0dfbeaa
to
c26bced
Compare
…here Found' step in 'close-discussion' workflow
c26bced
to
416ab76
Compare
6178f3d
to
51e13fa
Compare
See commit patches, or try running this workflow, and see its output.
…rstandable by Markdown - 'createchangelog' Workflow
5e6e21f
to
1982579
Compare
could you maybe if PR #2481 gets merged first change the logics to first run the docs script, then build the docs page and in the end do the release? |
Sure thing @MyDrift-user, I'll make sure to test it as well 👍 |
Make sure this also includes pre releases but make sure in docs it looks like a normal release to cause no issues in WinUtil. |
You are doing too much with this PR... Changing the names should be its own PR. That way we can easily see what changes with the workflows. I will close this in it's current state. |
Don't like the change in file name extensions as I can't analyze the difference between them well. |
Type of Change
Description
This PR Fixes the
close=discussion
workflow not working in specific edge cases (when there's no linking to any issue or discussion, bash will crash 😅, see commit 416ab76 for the fix), and fixescreatechangelog
workflow which won't work in specific instances, like when you edit/delete a release, or when main branch is updated (something to do withactions/checkout
action, plus how GitHub gives triggered Workflows theirref
& the derivedref_name
github environments/built-ins).Besides simple fixes highlighted above, it also tries to make future deployments of winutil easier, by making use of GitHub Actions Reusable Workflows, now you can run a single workflow that'll call another workflow, and so on (up until three-layers deep (4 including the triggered workflow), source).
Diagram
Testing
As shown in latest run using these changes (link to it), it works as intended.
Fixes to
close-discussion
can be seen in PR og-mrk#27 & its run (when the author of PR doesn't specify any issues/discussions), plus PR og-mrk#28 & its run (fails because the IDs given are either not valid (not found in current repo) or simply doesn't exist, or it isn't a discussion (maybe an issue)).The fix for
createchangelog
workflow is coming soon...Impact
Makes sure that the Changelog is up-to-date with every release.
Checklist