Update Phone Link Application ID in config/tweaks.json #2509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…crosoft.YourPhone' and remove redundant application ID 'Microsoft.CommsPhone'.
rumplin
approved these changes
Aug 3, 2024
…crosoft.YourPhone' and remove redundant application ID 'Microsoft.CommsPhone'.
Change Phone Link application ID from 'Microsoft.WindowsPhone' to 'Microsoft.YourPhone' and remove redundant application ID 'Microsoft.CommsPhone'.
12 tasks
|
Even though the reason behind closing it might seem insignificant... the fact you considered it and tried fixing it shows clear dedication.. or just wanna see a green Just to be clear, we don't enforce developers to sign their commits with a key (a GPG or a SHA), it's considered best practices, as it'll be used to verify that "yes, you're the one who made this commit, and you made it on your machine(s) that have the Key Pair installed/configured.", which's better to have setup then nothing to be honest. Also I've reviewed your new PR, thanks again for the fix @Cryostrixx 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Author Note
Pull Request #2509 - Status: Closed. Reason: Commit 2d79ed4 was missing a verified GPG signature.
The updated pull request can be found here: #2514 and the updated commit can be found here: 2c4ee66.
Title
Update Phone Link Application ID in config/tweaks.json.
Type of Change
Description
Change ID Microsoft.WindowsPhone to Microsoft.YourPhone and remove invalid ID Microsoft.CommsPhone in the WPFTweaksDeBloat function.
This fixes an issue where Phone Link was not getting uninstalled correctly when debloating the system using the Remove ALL MS Store Apps tweak.
Testing
Tested the change locally by running the compiled script and confirming that the Phone Link (Your Phone) application was correctly removed.
Impact
This change ensures the WPFTweaksDeBloat function uninstalls the correct Phone Link application and eliminates the redundant Microsoft.CommsPhone entry.
Issue related to PR
None.
Additional Information
None.
Checklist