Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MicroWin] Add try-catch block for AppX packages #2560

Merged

Conversation

CodingWonders
Copy link
Contributor

@CodingWonders CodingWonders commented Aug 14, 2024

Pull Request

Title

(Same as title, but with MicroWin prepended to avoid confusion with other PRs)

Type of Change

  • Bug fix

Description

This PR reinstates error handling for the AppX package removal function, which had been removed during the live stream on 13 August

Testing

AppX package removal still works

Impact

Reliability improvements

Issue related to PR

No issue. That's why I made this change - to prevent such issues from being reported

Additional Information

No documentation changes

Checklist

  • My code adheres to the coding and style guidelines of the project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no errors/warnings/merge conflicts.

Copy link
Owner

@ChrisTitusTech ChrisTitusTech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks forgot to put this back in.

@ChrisTitusTech ChrisTitusTech merged commit 4d2ea15 into ChrisTitusTech:main Aug 14, 2024
1 check passed
@CodingWonders CodingWonders deleted the microwin-fix-240814 branch August 15, 2024 07:53
@ChrisTitusTech ChrisTitusTech added the skip-changelog Skip Change Logs label Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-changelog Skip Change Logs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants