Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explorer Refresh instead of restart #2616

Closed
wants to merge 0 commits into from

Conversation

MyDrift-user
Copy link
Contributor

Pull Request

Explorer Refresh instead of restart

Type of Change

  • Refactoring

Description

Instead of restarting explorer, we could "refresh" it. For example when changing settings in the settings app it does not restart the explorer process, but still works fine. I am trying to recreate that.

Testing

  • Changes currently work with dark mode toggle and other light stuff, but not with snap window toggles for example.
  • I need to test it out more and take a deeper look at how Windows does it.

Impact

restarting explorer is kind of a trash experience, it would help the ux.

Checklist

  • My code adheres to the coding and style guidelines of the project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no errors/warnings/merge conflicts.

Comment on lines 37 to 38

Invoke-WinUtilExplorerRefresh
Copy link
Contributor

@og-mrk og-mrk Aug 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

... isn't calling Invoke-WinUtilExplorerRefresh on every toggle interaction maybe a bit over kill? 😅
I think it's better to call it when necessary, and it'll show a clear dependency on this ExplorerRefresh function for those functions that rely on it, which'll help with the devdocs-generator script as well, it'll be a win-win situation.. even if it's at the cost of extra lines of code.

@ChrisTitusTech ChrisTitusTech force-pushed the main branch 2 times, most recently from 7805fe4 to cfb9edb Compare August 26, 2024 22:01
@MyDrift-user MyDrift-user mentioned this pull request Sep 13, 2024
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants