Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify WinUtil Directory Creation in 'main.ps1' script #2654

Merged
merged 1 commit into from
Sep 10, 2024
Merged

Simplify WinUtil Directory Creation in 'main.ps1' script #2654

merged 1 commit into from
Sep 10, 2024

Conversation

og-mrk
Copy link
Contributor

@og-mrk og-mrk commented Aug 31, 2024

Type of Change

  • Hotfix

Description

Simplify WinUtil Directory Creation in 'main.ps1' script by using C# 'CreateDirectory' Method which checks and creates the provided Directory Path

Checklist

  • My code adheres to the coding and style guidelines of the project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no errors/warnings/merge conflicts.

@og-mrk
Simplify WinUtil Directory Creation in 'main.ps1' script by using C# …
3cee0a5 
…'CreateDirectory' Method which checks and creates the provided Directory Path
@og-mrk og-mrk requested a review from ChrisTitusTech as a code owner August 31, 2024 05:34
CodingWonders
CodingWonders approved these changes Aug 31, 2024
View reviewed changes
Copy link
Contributor

@CodingWonders CodingWonders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@og-mrk, we could have just done an Out-Null on New-Item, but this looks good too

@ChrisTitusTech ChrisTitusTech merged commit 1bfd8bd into ChrisTitusTech:main Sep 10, 2024
1 check passed
@ChrisTitusTech ChrisTitusTech added the skip-changelog Skip Change Logs label Sep 10, 2024
@og-mrk og-mrk deleted the simplify-winutil-directory-creation-in-main branch September 22, 2024 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Real-MullaC Real-MullaC Real-MullaC approved these changes

@CodingWonders CodingWonders CodingWonders approved these changes

@ChrisTitusTech ChrisTitusTech ChrisTitusTech approved these changes

Assignees
No one assigned
Labels
skip-changelog Skip Change Logs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@og-mrk @ChrisTitusTech @CodingWonders @Real-MullaC