Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add -Force flag for proper Hidden File detection in Invoke-Preprocessing.ps1 #2700

Merged

Conversation

ruxunderscore
Copy link
Contributor

Pull Request

Title

Added the -Force flag to the Get-ChildItem functions called at lines 80 and 90.

Type of Change

  • New feature
  • Bug fix
  • Documentation update
  • Refactoring
  • Hotfix
  • Security patch
  • UI/UX improvement

Description

This allows Preprocessing to properly detect hidden files in the directory. This prevents errors that I saw when running Compile.ps1, where the files .gitatrributes and .gitignore where not detected and caused Compile.ps1 to exit.

Testing

Tested compile before and after changes, and observed correct compilation behavior.

Impact

This should improve consistency with compiles across systems.

Issue related to PR

N/A

Additional Information

N/A

Checklist

  • My code adheres to the coding and style guidelines of the project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no errors/warnings/merge conflicts.

- Added `-Force` argument to Get-ChildItem functions at lines 80 and 90.
- Make changes to new Compile.ps1 file.
@ruxunderscore
Copy link
Contributor Author

Made changes based on new Compile.ps1 file.

@ChrisTitusTech ChrisTitusTech merged commit 3145882 into ChrisTitusTech:main Sep 10, 2024
1 check passed
@ChrisTitusTech ChrisTitusTech added the skip-changelog Skip Change Logs label Sep 10, 2024
@ruxunderscore ruxunderscore deleted the compile-preprocessing-fix branch September 24, 2024 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-changelog Skip Change Logs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants