Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Color fixes in the UI. #2722

Merged
merged 1 commit into from
Sep 12, 2024
Merged

Color fixes in the UI. #2722

merged 1 commit into from
Sep 12, 2024

Conversation

SHR1SHAK
Copy link
Contributor

@SHR1SHAK SHR1SHAK commented Sep 12, 2024

Fixed some colors which helps in better color contrast and fixed the text under the Update tab where the description is called default color. Added style to Textblock.

Type of Change

  • New feature
  • Bug fix
  • Documentation update
  • Refactoring
  • Hotfix
  • Security patch
  • UI/UX improvement

Description

Testing

Impact

Issue related to PR

  • Resolves #

Additional Information

Checklist

  • My code adheres to the coding and style guidelines of the project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no errors/warnings/merge conflicts.

…e blue and didn't had it own color. Fixed some color contrast issue
@SHR1SHAK
Copy link
Contributor Author

image
Left is before | Right is after fix

@SHR1SHAK
Copy link
Contributor Author

image
fixed border visibility and color of the header

image
Fixed color of DNS Button

@SHR1SHAK SHR1SHAK changed the title Color the Description in the Update tab where the text was talking th… Color fixes in the UI. Sep 12, 2024
Copy link
Owner

@ChrisTitusTech ChrisTitusTech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fixes, but for the future remove your formatter or prettier. This will be wiped out by the precompiler and the added whitespace would be typically denied.
Also it makes your changes harder to read which usually leads to a denied PR.

@ChrisTitusTech ChrisTitusTech merged commit a55a44a into ChrisTitusTech:main Sep 12, 2024
1 check passed
@SHR1SHAK
Copy link
Contributor Author

Sorry for that, I will have exclusion on this project for future updates

@Real-MullaC
Copy link
Contributor

Thanks for the fixes, but for the future remove your formatter or prettier. This will be wiped out by the precompiler and the added whitespace would be typically denied. Also it makes your changes harder to read which usually leads to a denied PR.

The whitespace removal was from the remove whitespace script. I think.

@SHR1SHAK
Copy link
Contributor Author

Thanks for the fixes, but for the future remove your formatter or prettier. This will be wiped out by the precompiler and the added whitespace would be typically denied. Also it makes your changes harder to read which usually leads to a denied PR.

The whitespace removal was from the remove whitespace script. I think.

i have prettifier extension on my vscodium so when I save it auto prettifies the code. I have already excluded this project now for the future update.

@Real-MullaC
Copy link
Contributor

Thanks for the fixes, but for the future remove your formatter or prettier. This will be wiped out by the precompiler and the added whitespace would be typically denied. Also it makes your changes harder to read which usually leads to a denied PR.

The whitespace removal was from the remove whitespace script. I think.

i have prettifier extension on my vscodium so when I save it auto prettifies the code. I have already excluded this project now for the future update.

Ok

@ChrisTitusTech ChrisTitusTech added the bug Something isn't working label Sep 15, 2024
Marterich added a commit to Marterich/winutil that referenced this pull request Sep 16, 2024
ChrisTitusTech pushed a commit that referenced this pull request Sep 20, 2024
* Setup for testing

* Working Example for Background

* Almost all MainBackgrounColor working

* Random Color PoC

* Fix DBorderColor

* prevent old logic from replacing colors in memory at startup

* Comment out resources in xaml

* Finish new Button

* Remove Pulse, Load Windows default Theme

* Fix Colors

* Fix Toggle Colors

* working version, with shared still being mostly applied be replace instead of resouces

* Load all entries in themes.json as Resource and reference them in inputXML.xaml

* Rename File to match Function Name

* Hotfix for Sync with main

* Remove Static Set-WinUtilUITheme function/file

* Rename File and Function

* Cleanup and Stuff

* Unify Button Theme with rest of UI

* Refactor/Optimazation

* Performance optimization

* Add Comments

* Rename Functions and Variables to be more concise and descriptive

* Add persistence to the user Theme Preference across winutil restarts

* Reimplement Theme Chagnes from #2722

* Add AUTO option to follow window theme and add dropdown instead toggle

* Formatting and deleting temp file

* Fix small display bug where Dropdown would remain open for settings and themes

* Remove terniary operators because only PS7+ is supported
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants