Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simple changes to 'Invoke-WPFTab' Public Function #2976

Conversation

og-mrk
Copy link
Contributor

@og-mrk og-mrk commented Oct 25, 2024

Type of Change

  • Simple improvements

Description

Simple changes to Invoke-WPFTab Public Function, please look into the commit history/actual changes to learn more about these changes.

Commit Summery:

  • f98d3be Improve 'Invoke-WPFTab' Parameter by specifying its type (as expected by the function) and make it Mandatory
  • c0e8a14 Simple performance increases in 'Invoke-WPFTab' function - Use where method instead of piping the result into Where-Object
  • 85d8db1 Remove commented-out code in 'Invoke-WPFTab' function

Testing

Switching between tabs works using the GUI as well as using the Shortcuts (Alt + I | T | C | U | M)

Impact

Not much of an impact, other then shaving a few milliseconds (at least in theory, didn't benchmark these changes to see if there's a noticeable difference).

Checklist

  • My code adheres to the coding and style guidelines of the project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no errors/warnings/merge conflicts.

@og-mrk og-mrk marked this pull request as ready for review October 25, 2024 10:18
@ChrisTitusTech ChrisTitusTech merged commit e2b9586 into ChrisTitusTech:main Nov 7, 2024
1 check passed
@og-mrk og-mrk deleted the simple-changes-to-Invoke-WPFTab-public-function branch November 12, 2024 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants