Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MicroWin] Fix function reference issue #3022

Merged
merged 1 commit into from
Nov 7, 2024

Conversation

CodingWonders
Copy link
Contributor

@CodingWonders CodingWonders commented Nov 7, 2024

Type of Change

  • Bug fix

Description

Important

PLEASE MERGE THIS BEFORE MAKING A RELEASE

Specifically, it fixes a reference issue for the "Recall fix", after the change made in #2888. Additional files in here are mere results from the compilation script.

Testing

Testing concluded successfully

Impact

Prevent people (and us) from having to deal with the FileExp manifest and its results (again)

Issue related to PR

None

Additional Information

No documentation changes required

Checklist

  • My code adheres to the coding and style guidelines of the project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no errors/warnings/merge conflicts.

Specifically, it fixes a reference issue for the "Recall fix". Thankfully, we're not making a release yet :)
Copy link
Contributor

@MyDrift-user MyDrift-user left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was me failing to sync main branch with my changes correctly.
Sorry!

@ChrisTitusTech ChrisTitusTech merged commit d619ee7 into ChrisTitusTech:main Nov 7, 2024
1 check passed
@CodingWonders CodingWonders deleted the microwin-241107 branch November 24, 2024 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants