Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong Bootstrap version in react-bootstrap #5292

Closed
crossan007 opened this issue Jul 3, 2020 · 1 comment · Fixed by #5293
Closed

Wrong Bootstrap version in react-bootstrap #5292

crossan007 opened this issue Jul 3, 2020 · 1 comment · Fixed by #5293
Labels
bug development Package Dependencies
Milestone
4.1.1

Comments

@crossan007
Copy link
Contributor

crossan007 commented Jul 3, 2020 •
edited
Loading

e80d281 bumped the version of @types/react-bootstrap and react-bootstrap to 1.0.1 from 0.32.20 which caused React to use Bootstrap 4, while the rest of AdminLTE uses bootstrap 3.

https://react-bootstrap-v3.netlify.app/getting-started/introduction

This mismatched version of Bootstrap causes the modal created by the calendar's "New Event" mechanism to be not-displayed: jquense/react-bootstrap-modal#35 (comment)
@crossan007
Copy link
Contributor Author

Discovered while working on #5291 #5287

@crossan007 crossan007 mentioned this issue Jul 3, 2020
Merged
@MrClever MrClever mentioned this issue Jul 20, 2020
Closed
@DawoudIO DawoudIO added this to the 4.1.1 milestone Aug 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug development Package Dependencies
Projects
None yet
Milestone
4.1.1
Development

Successfully merging a pull request may close this issue.

Bugfix/calendar issues ChurchCRM/CRM
2 participants
@DawoudIO @crossan007