Bugfix/calendar issues #5293
Merged
Bugfix/calendar issues #5293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrClever
approved these changes
Jul 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's this PR do?
Reverts react-bootstrap to use Bootstrap 3 instead of 4.
Fixes the data type of the
Datepassed to the calendar's event modal dialogWhat Issues does it Close?
Closes #5292
Closes #5291
Closes #5287
Steps to test:
Open the calendar view in 4.1.0, and click on either an existing event, or click in a "blank area" to create a new event
Observe the Javascript console indicates
RangeError: Invalid time value, and the dialog does not appear.Now, checkout this branch and run
npm installandnpm run build-react, then refresh the calendar page and observe that the steps above result in the modal dialog being displayed.