Bug/mailchip ajax cleanup #5267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…CRM/CRM into bug/mailchip-ajax-cleanup
DawoudIO
commented
Jun 15, 2020
| return true; | ||
| } | ||
| if ($this->hasKey) { | ||
| $rootAPI = $this->myMailchimp->get(""); |
There was a problem hiding this comment.
ensure we have an active mailchimp with subscribers in it
| $lists = $this->myMailchimp->get("lists")['lists']; | ||
| LoggerUtils::getAppLogger()->debug("MailChimp list enumeration took: ". $time->getMiliseconds(). " ms. Found ".count($lists)." lists"); | ||
| foreach($lists as &$list) { | ||
| $listmembers = $this->myMailchimp->get('lists/'.$list['id'].'/members',['count' => 100000]); |
There was a problem hiding this comment.
The number of records to return. Default value is 10. Maximum value is 1000
This was the issue as 100000 was kicking back 0 subs
| foreach ($lists as &$list) { | ||
| $list['members'] = []; | ||
| $listmembers = $this->myMailchimp->get('lists/' . $list['id'] . '/members', | ||
| [ |
MrClever
approved these changes
Jun 16, 2020
There was a problem hiding this comment.
As per chat with @DawoudIO in Gitter; this looks good to me and functions without any apparent regression bugs in my dev environments. However, I don’t have any data to test with except in production so have not completed functional testing. Given other developer’s successful testing, I’m comfortable merging this one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's this PR do?
-- list of members in CRM not in Mail Chimp list
-- list of MailChimp users not in CRM
Screenshots (if appropriate)
What Issues does it Close?
Closes #5268 #5269 #5270
How should this be manually tested?