Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add PHP 7.4 for Travis Testing #5426

Merged
merged 5 commits into from
Oct 17, 2020
Merged

Add PHP 7.4 for Travis Testing #5426

merged 5 commits into from
Oct 17, 2020

Conversation

DawoudIO
Copy link
Contributor

What's this PR do?

  • Ensure tests run on PHP 7.4

What Issues does it Close?

Closes #5334

@DawoudIO DawoudIO added this to the 4.2.0 milestone Oct 15, 2020
@DawoudIO
Copy link
Contributor Author

Current Error stopping 7.4

  Problem 1
    - Installation request for endroid/qr-code 3.9.3 -> satisfiable by endroid/qr-code[3.9.3].
    - endroid/qr-code 3.9.3 requires ext-gd * -> the requested PHP extension gd is missing from your system.

MrClever
MrClever approved these changes Oct 16, 2020
View reviewed changes
Copy link
Collaborator

@MrClever MrClever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works on my side running PHP 7.4.11 in test sytems

@DawoudIO
Copy link
Contributor Author

@crossan007 can you upgrade endroid/qr-code to the latest to see if that removes the need for gd lib or is there a way to install that on PHP 7.4.x

@DawoudIO DawoudIO marked this pull request as ready for review October 17, 2020 17:32
@DawoudIO DawoudIO requested a review from crossan007 as a code owner October 17, 2020 17:32
@DawoudIO DawoudIO merged commit ffb34f2 into master Oct 17, 2020
@DawoudIO DawoudIO deleted the build/php7.4-travis-tests branch October 17, 2020 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MrClever MrClever MrClever approved these changes

@crossan007 crossan007 Awaiting requested review from crossan007

Assignees
No one assigned
Labels
build Integration Testing
Projects
None yet
Milestone
4.2.0
Development

Successfully merging this pull request may close these issues.

Test support for PHP 7.4
2 participants
@DawoudIO @MrClever