Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle adjusting BasePath, utilizing discovered rootPath #6881

Conversation

grayeul
Copy link
Contributor

@grayeul grayeul commented Feb 19, 2024

Description & Issue number it closes

Closes #6880 - to address deploying churchcrm in a subdir of webserver root.

Screenshots (if appropriate)

N/A

How to test the changes?

Deploy in a subdir, e.g. /var/www/html/churchcrm

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Tested with a fresh git repository, and mapping src dir to /var/www/html/churchcrm. Verified that the initial setup of the ChurchCRM system proceeds correctly.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@DAcodedBEAT
Copy link
Contributor

(We need to consolidate the many routers at some point but) Great find!

I wonder if this is the issue many were facing when upgrading to newer versions of ChurchCRM (cc: @MrClever)

@DAcodedBEAT DAcodedBEAT added this to the vNext milestone Feb 19, 2024
@DAcodedBEAT DAcodedBEAT added bug Backend System php Pull requests that update Php code labels Feb 19, 2024
@DAcodedBEAT DAcodedBEAT merged commit 1d39439 into master Feb 19, 2024
4 checks passed
@DAcodedBEAT DAcodedBEAT deleted the 6880-bug-initial-setup-does-not-work-if-churchcrm-not-at-root-of-website branch February 19, 2024 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backend System bug php Pull requests that update Php code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Initial setup does not work if ChurchCRM not at root of website
2 participants