Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Locale: India (Hindi & Tamil), Japanese, and China (zh_CN) Flag #6930

Merged
merged 5 commits into from
Apr 6, 2024

Conversation

DawoudIO
Copy link
Contributor

@DawoudIO DawoudIO commented Apr 6, 2024

Description & Issue number it closes

  • Fixed zh_CN missing a flag
  • Added new locale, Japanese
  • Added new locales for India (Hindi & Tamil)
  • Reformat of locale.json
  • Download new locale files from POEditor

Screenshots (if appropriate)

image

How to test the changes?

Visit the user setting page:

  • look for new locale in dropdown,
  • ensure that the locale is selected and

Visit the Calendar page and see new locale used

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@DawoudIO DawoudIO requested a review from a team as a code owner April 6, 2024 19:14
@DawoudIO DawoudIO requested review from grayeul, DAcodedBEAT and MrClever and removed request for a team April 6, 2024 19:14
@DawoudIO DawoudIO added this to the 5.7.0 milestone Apr 6, 2024
@DawoudIO
Copy link
Contributor Author

DawoudIO commented Apr 6, 2024

image

@DawoudIO DawoudIO merged commit 7dd2780 into master Apr 6, 2024
4 checks passed
@DawoudIO DawoudIO deleted the locale/new-5.7.0 branch April 6, 2024 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant