Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Birthday Calendar works for only current year. #6991 #6995

Merged
merged 2 commits into from
May 4, 2024

Conversation

bigtigerku
Copy link
Contributor

Description & Issue number it closes

Bug: Birthday Calendar works for only current year. #6991

Screenshots (if appropriate)

Before

Screenshot 2024-05-04 at 9 24 32 AM

After

Screenshot 2024-05-04 at 10 31 39 AM

How to test the changes?

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

From local host with

num run package
npm run docker-test-start

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@bigtigerku bigtigerku requested a review from a team as a code owner May 4, 2024 17:34
@bigtigerku bigtigerku requested review from respencer, DawoudIO, grayeul, DAcodedBEAT and MrClever and removed request for a team May 4, 2024 17:34
@DawoudIO DawoudIO added the bug label May 4, 2024
@DawoudIO DawoudIO added this to the vNext (5.8.0) milestone May 4, 2024
@DawoudIO
Copy link
Contributor

DawoudIO commented May 4, 2024

Thanks for helping and welcome to the team @bigtigerku . Let me test and approve

@DawoudIO DawoudIO self-assigned this May 4, 2024
Also remove redundant "Birthday: " string
@bigtigerku
Copy link
Contributor Author

I also removed redundant "Birthday: " string.

@DawoudIO
Copy link
Contributor

DawoudIO commented May 4, 2024

Looks good for 2025, but empty in 2026... so better but unsure what is the best way, we can't go forward forever...

@bigtigerku
Copy link
Contributor Author

Looks good for 2025, but empty in 2026... so better but unsure what is the best way, we can't go forward forever...

As I mentioned #6991
I am OK with only current year for performance except December. So I changed it to display birthdays of current and next year :-)

@DawoudIO DawoudIO merged commit 298025c into ChurchCRM:master May 4, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants