Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mismatched date formatting #7002

Merged

Conversation

respencer
Copy link
Contributor

Resolves #7001

Description & Issue number it closes

Almost all other date formatting is long format (the exception being birth dates with no year), this resolves the mismatch.

Resolves #7001

Screenshots (if appropriate)

Before:

Screenshot_20240506_202745

After:

Screenshot_20240506_213049

How to test the changes?

Visual inspection.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Visual inspection.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@respencer respencer requested a review from a team as a code owner May 6, 2024 19:40
@respencer respencer requested review from DawoudIO, grayeul, DAcodedBEAT and MrClever and removed request for a team May 6, 2024 19:40
@DawoudIO DawoudIO merged commit 8eb5191 into ChurchCRM:master May 7, 2024
3 checks passed
@DawoudIO DawoudIO added this to the Current (5.8.0) milestone May 7, 2024
@respencer respencer deleted the 7001-fix-mismatched-date-formatting branch May 7, 2024 06:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wedding Date in wrong order on Directory Report
3 participants