feature(run-task): add run-task command

[codingdiaz]

#10

This wraps aws ecs run-task with basic logic. I would love to work to get this merged (can update change / write tests etc.) I know of a couple teams that also want this functionality.

I can also add examples.

[lokst]

Thanks @codingdiaz, I'm excited for this! Could you add a job that wraps this command too? Would you be able to also add an example for this under examples in src/orb.yml.hbs ?

[codingdiaz]

@lokst of course. I’ll do that today.

I also didn’t know if an environment variable should be set or if I should handle any of the output from the run command. There are some times where the command runs fine but a task is never launched.

I also was unsure how to implement polling of a task. I was thinking just a job that gets the status every 30 seconds or so. What do you think?

[codingdiaz]

@lokst I updated this PR to include a run-task job and two examples for running a fargate task and an ec2 task. Let me know if anything needs to be modified / added etc.

I was slightly unsure what to put for the version of this orb in my examples since it will be a future release. I was unsure if automation updates that on new releases.

[sgerrand]

🤔 Surely both of these values should be stubbed out and be required to have "real" values injected at runtime?

[codingdiaz]

Hmm what do you mean @sgerrand ?

[sgerrand]

👋 Apologies. I should have been clearer in my previous comment.

I meant that the values for the keys in this step (e.g. subnet-ids and security-group-ids) are using "real" values. Other examples in this file are using variables for substitution–perhaps this should use the same approach?

[codingdiaz]

Do you mean for example:

subnet-ids: $SUBNET_ONE, $SUBNET_TWO

[lokst]

I think the real values are helpful as an example of what typical values would look like. Perhaps something like this would be nice?

# e.g. "subnet-70faa93b,subnet-bcc54b93"
subnet-ids: $SUBNET_ONE, $SUBNET_TWO
# e.g. "sg-010a460f7f442fa75"
security-group-ids: $SECURITY_GROUP_IDS

[lokst]

@codingdiaz Thanks for the updates! For the examples you could also use circleci/aws-ecs@x.y.z since the version number of the release is unclear. I would like to review your changes asap, but as I'll be away most of the week, I may not be able to get to it till next week.

[lokst]

@codingdiaz This looks great! Could you review my suggestions?

[codingdiaz]

@codingdiaz This looks great! Could you review my suggestions?

Hey @lokst I incorporated those comment, thanks! Anything else that should be changed for this PR?

[lokst]

@codingdiaz This looks almost ready to be merged! Could you review my comment and also merge the latest changes from master again?

[lokst]

@codingdiaz Your changes are now published in circleci/aws-ecs@0.0.13 ! 🎉